Skip to content

Add command for "list-outdated"#586

Draft
isc-shuliu wants to merge 2 commits intomainfrom
v1next-update-outdated
Draft

Add command for "list-outdated"#586
isc-shuliu wants to merge 2 commits intomainfrom
v1next-update-outdated

Conversation

@isc-shuliu
Copy link
Contributor

@isc-shuliu isc-shuliu commented Oct 16, 2024 •
edited
Loading

Implement an outdated command mentioned in #427

@isc-shuliu isc-shuliu mentioned this pull request Oct 16, 2024
Closed
@isc-kiyer
Copy link
Collaborator

isc-kiyer commented Oct 16, 2024

@isc-shuliu this PR is related to #550 where part of running "update" should upgrade a module and run its upgrade steps (if any).

@isc-shuliu
Copy link
Contributor Author

isc-shuliu commented Oct 16, 2024

@isc-shuliu this PR is related to #550 where part of running "update" should upgrade a module and run its upgrade steps (if any).

Thanks for the heads-up! I'm aware of that hence posting it as a draft.

@isc-shuliu isc-shuliu changed the title Add command for "update" and "outdated" Add command for "outdated" Oct 22, 2024
@isc-kiyer isc-kiyer changed the title Add command for "outdated" Add command for "list-outdated" Oct 22, 2024
isc-kiyer
isc-kiyer reviewed Oct 22, 2024
View reviewed changes
src/cls/IPM/Main.cls
}
}

ClassMethod CanUpdate(modName As %String, semver As %IPM.General.SemanticVersion) As %Boolean
Copy link
Collaborator

@isc-kiyer isc-kiyer Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isc-shuliu Doesn't look like this method is used?

Copy link
Contributor Author

@isc-shuliu isc-shuliu Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. I haven't gone to that point yet. My plan is to show if an outdated package can be updated to a particular version without violating dependency constraint. This PR is still a Work-In-Progress

Base automatically changed from v0.10.x to main April 10, 2025 15:05
@AshokThangavel
Copy link
Contributor

AshokThangavel commented Mar 8, 2026

Hi @isc-shuliu and @isc-kiyer
would like to check on the status of this PR. The list-outdated command would be a very valuable addition to the workflow. Is this still considered work-in-progress.
Also, if it helps move things forward, would you be open to integrating this logic into the existing list-installed command instead (perhaps via an --outdated or -o flag)? I’d be happy to implement it if that's a direction you'd like to take.
Thank you!

@isc-dchui
Copy link
Collaborator

isc-dchui commented Mar 9, 2026

@AshokThangavel this work is definitely sitting around unowned at the moment, so feel free to pick it up. Note that this change was started before the update command was added so its implementation should now take that into consideration. I would agree that adding a -outdated/-o flag to the list command seems like a good approach.

@AshokThangavel
Copy link
Contributor

AshokThangavel commented Mar 9, 2026

Hi @isc-dchui
Thanks for the feedback, I'll implement it as a -outdated (and -o) flag within the existing list command. I'll also ensure the logic aligns with the newer update command infrastructure to keep things consistent.

@AshokThangavel
Copy link
Contributor

AshokThangavel commented Mar 10, 2026

Hi @isc-dchui
I've noticed in the module search results between two different API calls. When I use ##class(%IPM.Repo.Utils).SearchRepositoriesForModule(tSearchCriteria,.results) , it only returns 109 entries and is missing several expected modules.
However, when I execute ##class(%IPM.Main).GetUpstreamPackageVersions(.modules) it returns over 500 modules.

@isc-dchui
Copy link
Collaborator

isc-dchui commented Mar 10, 2026

@AshokThangavel Oh interesting. I'm not too familiar with the differences between them so I'd say go explore and figure out which is appropriate in this situation (and why they're different in the first place).

@AshokThangavel AshokThangavel mentioned this pull request Mar 10, 2026
Open
@AshokThangavel
Copy link
Contributor

AshokThangavel commented Mar 10, 2026 •
edited
Loading

Thank you! The GetUpstreamPackageVersions provides the maximum metadata needed for version comparison. I've implemented the fix using this approach and submitted the Pull Request. I appreciate the guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isc-kiyer isc-kiyer isc-kiyer left review comments

@isc-eneil isc-eneil Awaiting requested review from isc-eneil isc-eneil will be requested when the pull request is marked ready for review isc-eneil is a code owner

@isc-jili isc-jili Awaiting requested review from isc-jili isc-jili will be requested when the pull request is marked ready for review isc-jili is a code owner

@isc-jlechtne isc-jlechtne Awaiting requested review from isc-jlechtne isc-jlechtne will be requested when the pull request is marked ready for review isc-jlechtne is a code owner

@isc-egabhart isc-egabhart Awaiting requested review from isc-egabhart isc-egabhart will be requested when the pull request is marked ready for review isc-egabhart is a code owner

@isc-pbarton isc-pbarton Awaiting requested review from isc-pbarton isc-pbarton will be requested when the pull request is marked ready for review isc-pbarton is a code owner

@isc-dchui isc-dchui Awaiting requested review from isc-dchui isc-dchui will be requested when the pull request is marked ready for review isc-dchui is a code owner

@isc-tleavitt isc-tleavitt Awaiting requested review from isc-tleavitt isc-tleavitt will be requested when the pull request is marked ready for review isc-tleavitt is a code owner

@isc-cborbonm isc-cborbonm Awaiting requested review from isc-cborbonm isc-cborbonm will be requested when the pull request is marked ready for review isc-cborbonm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isc-shuliu @isc-kiyer @AshokThangavel @isc-dchui